-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
slider onchange event improvement #4921
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Refactor debouncing and throttling implementation for effectiveness
Defining
throttledUpdate
anddebouncedUpdate
inside thehandleKeyDown
function creates new instances on every key press, which means the debouncing and throttling won't work as intended. Additionally, applying debouncing and throttling to theEnter
key event is unnecessary since it's a discrete action.To effectively limit the number of times
onChange
is called due to user input, consider applying debouncing to thehandleInputChange
function or theonChange
handler of the input fields. This way, the debounced functions are maintained across renders and are only created once.Suggested refactor: Apply debouncing to input change handlers
Move the debouncing logic outside of the
handleKeyDown
function and apply it to the input change handlers usinguseCallback
anduseRef
. Here's how you can modify the code:This refactor moves the debouncing logic to the
handleInputChange
function, which is called on every input change. The debounced functiondebouncedUpdate
is memoized usinguseCallback
, ensuring it retains state across renders and effective debouncing is applied.