-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] refactor js operator runtime #4949
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the name of this file:
-useExectuionContext.test.tsx
+useExecutionContext.test.tsx
* @returns {UseInvocationRequestQueueReturn} - An object containing requests, success, and error handling functions. | ||
*/ | ||
export default function useInvocationRequestQueue(): UseInvocationRequestQueueReturn { | ||
const ref = useRef<InvocationRequestQueue>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the lifecycle of the queue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a readme to answer this question!
Refactors the JS operator runtime into a separate submodule that matches the existing interfaces. All the code is the same, but now factored into tiny testable bite sized files/functions.
This also includes a new unit (as in the runtime sub modules is the unit) test suite.