[WIP] refactor js operator runtime #4949
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleven
reviewed
Oct 19, 2024
There was a problem hiding this comment.
There's a typo in the name of this file:
-useExectuionContext.test.tsx
+useExecutionContext.test.tsx
kaixi-wang
reviewed
Oct 20, 2024
| * @returns {UseInvocationRequestQueueReturn} - An object containing requests, success, and error handling functions. | ||
| */ | ||
| export default function useInvocationRequestQueue(): UseInvocationRequestQueueReturn { | ||
| const ref = useRef<InvocationRequestQueue>(); |
There was a problem hiding this comment.
What is the lifecycle of the queue?
There was a problem hiding this comment.
I've added a readme to answer this question!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the JS operator runtime into a separate submodule that matches the existing interfaces. All the code is the same, but now factored into tiny testable bite sized files/functions.
This also includes a new unit (as in the runtime sub modules is the unit) test suite.