Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/updates vrt #142

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Feature/updates vrt #142

merged 3 commits into from
Dec 12, 2024

Conversation

zipkid
Copy link
Member

@zipkid zipkid commented Dec 12, 2024

  • Make indenting in puppetserver.conf consistent
  • Only write csr_attributes.yaml file if the env var CSR_ATTRIBUTES has content. This file is not required for normal functioning.
  • Allow running custom entrypoint scripts before the default scripts run. In this case, I need to run a script that creates csr_attributes.yaml with data from AWS ECS metadata and that needs to exist before the CA script auto-signs the server script.

@zipkid zipkid requested a review from a team as a code owner December 12, 2024 08:38
@rwaffen rwaffen enabled auto-merge December 12, 2024 08:49
@rwaffen rwaffen merged commit 44f6b22 into voxpupuli:main Dec 12, 2024
11 checks passed
@zipkid zipkid deleted the feature/updates-vrt branch December 12, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwaffen rwaffen rwaffen approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Crafty Overview
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zipkid @bastelfreak @rwaffen