Update and fix GitHub Actions release workflow #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaffen
approved these changes
Nov 8, 2023
|
@ldaneliukas may you please sign all you commits? |
|
i will close this, the build has changed at all and this is not needed anymore. if you think otherwise let us know and we can repoen this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current workflow passes a build argument
PUPPET_VERSIONwhilst the Dockerfile does not use it, instead it expectsPUPPETSERVER_VERSION.Reworked the workflow so that the same job can be used to release different versions of Puppetserver depending the tag that triggered the workflow run.