Data that looks like a URI but is invalid should be treated as a string #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainbeeston
force-pushed
the
treat-invalid-uris-as-strings
branch
from
80f4740
to
b9ebce0
Compare
|
@RST-J Could I please get a review of this too? |
|
Sorry, I'm currently not able to review. I have RL stuff to deal with.
Bis neulich
Jonas
Gesendet mit BlueMail
Am 5. Juli 2017, 19:36, um 19:36, Iain Beeston <notifications@github.com> schrieb:
…
@RST-J Could I please get a review of this too?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#386 (comment)
|
|
@RST-J No problem, I understand completely (sorry for spamming you with requests!) |
string There's a bug where if you pass a string as data and it looks like a URI, we try to parse it and load the data from that location. However, if parsing fails, we should give up trying to load remote data and treat the data as a string instead.
iainbeeston
force-pushed
the
treat-invalid-uris-as-strings
branch
from
b9ebce0
to
d5a4ebd
Compare
|
This seems like it is still a problem, @bastelfreak could you take a look? |
|
There's at least a merge conflict so it needs a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug where if you pass a string as data and it looks like a
URI, we try to parse it and load the data from that location. However,
if parsing fails, we should give up trying to load remote data and
treat the data as a string instead.