Fix accessing files via Java ClassLoader in JRuby #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes access to files accessed through Java ClassLoader in JRuby
olleolleolle
reviewed
Jan 4, 2018
| Addressable::URI.convert_path(parsed_uri.path) | ||
| if not parsed_uri.scheme.nil? | ||
| parsed_uri | ||
| else |
There was a problem hiding this comment.
The conditional would read better as if parsed_uri.scheme
There was a problem hiding this comment.
Yep, makes sense. I'll edit the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should fix #47 and probably #326 . It fixes access to files embedded in Java applications.
It might be wise to make the changes in some other way, the fix is not very nice (it basically just checks some specific conditions in current code).