Specify dependent module in dependencies #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the origin of the dependency to verbose output, making it easier to determine which source/module is causing a conflict. For example: Failed to resolve puppetlabs-concat (= 5.1.1) <https://forgeapi.puppetlabs.com> becomes Failed to resolve puppetlabs-concat (= 5.1.1) <https://forgeapi.puppetlabs.com> (from Puppetfile)
|
This is a really annoying problem you're solving so a big thanks. I'm not really familiar with the code base. Would it be possible to have tests for this? |
|
I'm sure I could come up with some tests. I ended up having to bring over entire methods from librarianp in order to alter dependency initialization, but now I'm wondering if it doesn't make more sense to add this feature to librarianp in order to limit the required changes to this gem. Thoughts? |
ekohl
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the origin of the dependency to verbose output, making it easier to determine which
source/module is causing a conflict.
For example:
becomes