Fix calling issue with open-uri #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the deprecation of using `Kernel#open` directly, `open-uri`
started issuing a warning to not use `open` without being called with
the appropriate wrappers.
This apparently interfers with the monkey-patched
`Librarian::Puppet::Logger#warn` method by passing two arguments:
```
warn('calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open', uplevel: 1)
[...]
1: from /home/twolter/.gem/ruby/2.7.0/gems/librarian-puppet-3.0.0/lib/librarian/puppet/util.rb:15:in `warn'
/opt/puppetlabs/bolt/lib/ruby/gems/2.7.0/gems/librarianp-1.0.0/lib/librarian/logger.rb:15:in `warn': wrong number of arguments (given 2, expected 0..1) (ArgumentError)
```
With this commit, `open` has been replaced by `URI.open` which works
perfectly.
ekohl
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the deprecation of using
Kernel#opendirectly,open-uristarted issuing a warning to not useopenwithout being called with the appropriate wrappers.This apparently interfers with the monkey-patched
Librarian::Puppet::Logger#warnmethod by passing two arguments:With this PR,
openhas been replaced byURI.open, which works perfectly.