Improve $packages data-types consistency #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pluralized name implies an array of String, however the parameter was a String. Change it to Array[String] for consistenty.
These are arrays, but only array of String to make sense. Restrict the types checking to such arrays.
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$bacula::client::packageswas aStringwhile$bacula::director::packagesand$bacula::storage::packageswhereArray(without type restriction for the items).It probably makes sense to consistently use an
Array[String]for these variables.End users should be unaffected by this change unless they customized these variables to pass custom package name for
$bacula::client::packages(which I believe is uncommon).This problem was found when checking variable data-types consistency while working on switching from erb to epp.