Modernize and fix style #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- A leading `::` was required in old puppet versions (up to 3.x), but Puppet 4 and newer does not require this anymore; - Ensure all parameter are always followed by a `,`.
|
Meh… I just fixed the CI by removing the deprecated / not-recommended check, but I guess the Gemfile is managed by modulesync and this change may be counter-productive 😒 I'll fill-in a PR in the modulesync_config repository. If you want, I can remove this last commit (Remove puppet-lint-absolute_classname-check). Edit: ☑️ done: zachfi/modulesync_config#1 |
Instead of a String and a lefacy validate_re statement, rely on the Enum data-type.
This type was previously introduced. We can use it instead of plain String with legacy validate_re.
An Array data-type does not enforce any restrictions on the items in the array, which is prone to error. Improve validation by always passing the type of the items of the array.
Quoting the check README: > Including a class by a relative name might lead to unexpected results > in Puppet 3. This plugin is not recommended for use with Puppet code > that has dropped support for Puppet 3 (EOL 20161231). https://github.com/voxpupuli/puppet-lint-absolute_classname-check
|
I'm a little behind on the module_sync and I think the practices are shifting a bit now with PDK out. Its hard to know which approaches are best. You are great. Thanks for the other PR too. I'll get that applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::was required in old puppet versions (up to 3.x), but Puppet 4 and newer does not require this anymore;,.