Switch to Bacula 9 on FreeBSD #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Probably the tests need to be updated for the new package name to pass. If its more complicated than that I can take a closer look. |
|
D'oh, I committed the fix to my repo, updated my Puppetfile to use it, opened a Pull Request and did not bother to watch the CI failing 😕 Let me fix that, as far as I can see, failures are caused by failing to update the test suite and legacy versions of Ruby that have reached EOL. |
sysutils/bacula-client and sysutils/bacula-server install Bacula 7 which is not supported anymore. The ports have been marked as [DEPRECATED] in November 2017 with EXPIRATION DATE set to 2019-03-01. Two new ports where added some times before for Bacula 9: - sysutils/bacula9-client - sysutils/bacula9-server Default to use these up-to-date ports instead of the legacy ones. [DEPRECATED]: http://svnweb.freebsd.org/changeset/ports/484470
Run the test suite against supported versions of Ruby and Puppet, that is Ruby 2.4.5 and Puppet 5.x (matching puppet-agent 5.5.10) and Ruby 2.5.3 and Puppet 6.x (matching puppet-agent 6.2.0). https://puppet.com/docs/puppet/5.5/about_agent.html https://puppet.com/docs/puppet/6.2/about_agent.html
|
Should be better 😉 Sorry for triggering the pull-request trigger too fast and not checking the build status. |
|
Totally cool to open PRs. Getting the tests to run is useful sometimes. Good to hear from you again. Hope you are well. Thanks for the change. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysutils/bacula-clientandsysutils/bacula-serverinstall Bacula 7 which is not supported anymore. The ports have been marked as DEPRECATED in November 2017 with EXPIRATION DATE set to 2019-03-01.Two new ports where added some times before for Bacula 9:
sysutils/bacula9-clientsysutils/bacula9-serverDefault to use these up-to-date ports instead of the legacy ones.