Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jobs' $selection_pattern #144

Merged
merged 2 commits into from
Sep 8, 2019
Merged

Fix jobs' $selection_pattern #144

merged 2 commits into from
Sep 8, 2019

Conversation

smortex
Copy link
Member

@smortex smortex commented Sep 6, 2019

When $selection_pattern is set, we expect a new "Selection Pattern" entry to be emitted, not a "Selection Type" entry.

@smortex
Fix jobs' $selection_pattern
36ad940 
When $selection_pattern is set, we expect a "Selection Pattern" entry to
be emitted, not a "Selection Type" entry.
@smortex
Rework 7a12da9
c95ec0f 
Switching from Stdlib::Ip_address to Stdlib::IP::Address seems to not
satisfy Travis-CI completely.  Simplify the code to cope with address
expressed as hostname and not IP addresses since this is also supported.
@smortex
Copy link
Member Author

smortex commented Sep 6, 2019

I encountered some unexpected failure on Travis-CI… Added a commit to workaround this issue, but it looks like some more love to the (Dir|Fd|Sd)Addresses would be welcome to allow setting multiple addresses or not specify the setting at all.

Currently, it is not possible to not have a (Dir|Fd|Sd)Addresses produced because the optional value defaults to $facts['ipaddress']. Not sure if it is worth opening an issue though…

@zachfi
Copy link
Contributor

zachfi commented Sep 8, 2019

Good changes, thank you for the PR. Not sure why the addresses started failing, but the template clean up here looks good to me.

@zachfi zachfi merged commit 89d6111 into master Sep 8, 2019
@zachfi zachfi deleted the fix-selection-pattern branch September 8, 2019 21:55
@smortex smortex added the bug Something isn't working label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smortex @zachfi