Allow defining additional Tomcat connectors #205
Conversation
Add a new, optional class parameter `confluence::tomcat_additional_connectors` whose value is a well-formed, complex hash as described by the new type aliases `Confluence::Tomcat_connectors` and `Confluence::Tomcat_attributes`. Each hash key represents a port number, and the key's value is a hash that describes the connector's attributes and their values. Useful for defining additional HTTP ports through which to access Confluence. A typical use case is when Jira and Confluence run behind a reverse proxy and application links between Jira and Confluence must be set up. Then it is often better to allow Jira and Confluence to communicate directly instead of through the reverse proxy, but this requires a Tomcat connector that is configured for direct access instead of reverse proxy access (`proxyName`, `proxyPort`, etc). Described here: https://confluence.atlassian.com/kb/how-to-create-an-unproxied-application-link-719095740.html Contains spec tests, documentation and examples. A very similar PR was submitted to puppet-jira in voxpupuli/puppet-jira#316
antaflos
force-pushed
the
additional_connectors
branch
from
b147142
to
bb1b495
Compare
|
I don't know why the tests fail for Puppet 5.x and not for 6.x. The errors in https://travis-ci.org/github/voxpupuli/puppet-confluence/jobs/712602003 have nothing to do with the changes from this PR: |
|
that's all whitespace errors in files you didn't touch, so i reckon we can ignore this for your PR, and see to get it fixed separately. |
|
Dear @antaflos, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Closing and reopening to trigger Travis, maybe the test failures unrelated to this change are now fixed. |
|
The checks now pass so if the PR could be merged, that'd be great :) |
Add a new, optional class parameter
confluence::tomcat_additional_connectorswhose value is a well-formed,complex hash as described by the new type aliases
Confluence::Tomcat_connectorsandConfluence::Tomcat_attributes.Each hash key represents a port number, and the key's value is a hash
that describes the connector's attributes and their values.
Useful for defining additional HTTP ports through which to access
Confluence. A typical use case is when Jira and Confluence run behind a
reverse proxy and application links between Jira and Confluence must be
set up. Then it is often better to allow Jira and Confluence to
communicate directly instead of through the reverse proxy, but this
requires a Tomcat connector that is configured for direct access instead
of reverse proxy access (
proxyName,proxyPort, etc). Described here:https://confluence.atlassian.com/kb/how-to-create-an-unproxied-application-link-719095740.html
Contains spec tests, documentation and examples.
A very similar PR was submitted to puppet-jira in voxpupuli/puppet-jira#316