Prepared Queries #288
Merged
Prepared Queries #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the WIP that I added in the title and squash/rebase when you are ready for review. |
Update the readme file to show usage Add unit test for the new provider
djtaylor
force-pushed
the
preparedQueries
branch
from
2167b07
to
0b9ad9e
Compare
|
LGTM? I've not personally used (or even heard tbh) of this feature of consul before now. Writing providers can be tricky, it looks pretty sane and you have a few tests :) Shipping! |
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
Prepared Queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new provider for prepared queries API