Test changes for property #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw i tested on my local environment, and it works. test case run fine on my local machine. p.s. your acceptence testing doesn't seem to work properly. it seem it hit this issue voxpupuli/puppet-archive#225 so tested the module change directly on real server instead |
|
@solarkennedy @jk2l Is this resolved? If so, can we please merge this as this PR fixes an issue we are hitting. |
|
tbh i am not sure did the author even read it... |
|
I saw that the tests were failing and assumed you would be iterating. I've rerun the tests and looks like it was something transient. Merging! |
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
Test changes for property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consul_key_value currently don't update if there is changes in value because it is set to param instead of property
also protocol has no state within this type, so it shouldn't be property as well