Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No dependency on Module Concat #17

Closed
pjfoley opened this issue Jan 23, 2013 · 4 comments
Closed

No dependency on Module Concat #17

pjfoley opened this issue Jan 23, 2013 · 4 comments

Comments

@pjfoley
Copy link

pjfoley commented Jan 23, 2013

Hi,

Just walking through a howto to setup Razor and as part of this process installed the puppetlabs-dhcp. This has a clean install of puppet and puppetmaster. Following the guide these are the commands I have run:

puppet module install puppetlabs-razor
puppet apply /etc/puppet/modules/razor/tests/init.pp --verbose

puppet module install zleslie/dhcp
puppet apply /etc/puppet/modules/dhcp/tests/init.pp --verbose

Running the dhcp tests init.pp file it complains that it could not find class concat::setup.

I think the forge module file needs to include a dependacy on concat::setup.

Peter

@nanliu
Copy link
Contributor

nanliu commented Jan 23, 2013

I don't think it's the same module. There is a dependency in this module to concat: https://github.com/puppetlabs/puppetlabs-dhcp/blob/master/Modulefile

@pjfoley
Copy link
Author

pjfoley commented Jan 24, 2013

I am not in front of my computer at the moment but I will see if there is
anything in the installed dhcp module directory to show what dependencies
it thinks it has

On Thursday, January 24, 2013, Nan Liu wrote:

I don't think it's the same module. There is a dependency in this module
to concat:
https://github.com/puppetlabs/puppetlabs-dhcp/blob/master/Modulefile


Reply to this email directly or view it on GitHubhttps://github.com//issues/17#issuecomment-12628728.

@pjfoley
Copy link
Author

pjfoley commented Jan 24, 2013

I can confirm that the module file is not the one you linked to on master, it is the one in the 1.1.0 tag which is https://github.com/puppetlabs/puppetlabs-dhcp/blob/1.1.0/Modulefile

So it looks like when master was fixed it was never pushed to the forge with the updated modulefile.

It should just be a simple case (assuming there are no other changes that need to go through revision) just pushing an updated forge package?

@juniorsysadmin
Copy link
Member

No longer appears to be the case, closing. (Newer version will be published to the Forge soon if it hasn't been already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants