allow dhcp::host to override default- and max-lease-time #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jflorian Thanks! Could you look at the failing tests? (Whitespace differences? and rubocop warnings). Otherwise, looks good! |
|
I'll have to take a look at the errors tomorrow. I got tired of waiting them to finish and have never written tests for Puppet code before just lots of Puppet code. So it was kind of a logical gamble that it should work. CI testing Puppet code has been on my learning list forever, but I never have the time. Sigh!!! |
jflorian
force-pushed
the
host_lease_times
branch
3 times, most recently
from
596b608 to
5f9df10
Compare
bastelfreak
reviewed
Mar 8, 2019
bastelfreak
added
enhancement
bastelfreak
force-pushed
the
host_lease_times
branch
from
5f9df10 to
d77759f
Compare
This can be used where there's a need to have individual hosts vary from those set for the subnet or globally. Signed-off-by: John Florian <jflorian@doubledog.org>
bastelfreak
force-pushed
the
host_lease_times
branch
from
d77759f to
216fcd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used where there's a need to have individual hosts vary from
those set for the subnet or globally.
Signed-off-by: John Florian jflorian@doubledog.org
Pull Request (PR) description
I have use cases where I want certain hosts to have shorter DHCP lease times than those I prefer for global defaults. The ISC DHCP daemon allows overriding the
max-lease-timeanddefault-lease-timeparameters within a host record, now this module can too. Both of these settings are entirely optional. If you don't define them, the global (i.e.,dhcpdclass) defaults are used as before and there's no difference in thedhcpd.hostsfile.Ideally, this would be extended to
dhcp::poolas well, because IIRC that too is possible, but I don't have that need.This Pull Request (PR) fixes the following issues
none created