Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum stdlib version to 4.25.0 and use some of the newer types #217

Merged
merged 1 commit into from
Mar 2, 2019
Merged

Update minimum stdlib version to 4.25.0 and use some of the newer types #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manifests/host.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# == Define: dhcp::host
#
define dhcp::host (
Stdlib::Compat::Ip_address $ip,
Stdlib::IP::Address $ip,
Dhcp::Mac $mac,
String $ddns_hostname = $name,
Hash $options = {},
String $comment ='',
String $comment = '',
Boolean $ignored = false,
) {

Expand Down
6 changes: 3 additions & 3 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
#
class dhcp (
Optional[Array[String]] $dnsdomain = undef,
Array[Stdlib::Compat::Ipv4] $nameservers = [],
Array[Stdlib::Compat::Ipv6] $nameservers_ipv6 = [],
Array[Stdlib::IP::Address::V4] $nameservers = [],
Array[Stdlib::IP::Address::V6] $nameservers_ipv6 = [],
Array[String] $ntpservers = [],
Array[String] $dnssearchdomains = [],
String $dhcp_conf_header = 'INTERNAL_TEMPLATE',
Expand All @@ -30,7 +30,7 @@
Integer $max_lease_time = 86400,
$service_ensure = running,
$globaloptions = '',
Optional[Integer[0,65535]] $omapi_port = undef,
Optional[Stdlib::Port] $omapi_port = undef,
Optional[String] $omapi_name = undef,
String $omapi_algorithm = 'HMAC-MD5',
Optional[String] $omapi_key = undef,
Expand Down
4 changes: 2 additions & 2 deletions manifests/pool.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# == Define: dhcp::pool
#
define dhcp::pool (
Stdlib::Compat::Ipv4 $network,
Stdlib::Compat::Ipv4 $mask,
Stdlib::IP::Address::V4 $network,
Stdlib::IP::Address::V4 $mask,
$gateway = '',
$range = '',
$failover = '',
Expand Down
5 changes: 1 addition & 4 deletions manifests/pool6.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
# == Define: dhcp::pool6
#
define dhcp::pool6 (
# the ipv6 regex is currently wrong so we can't use it here
# https://github.com/puppetlabs/puppetlabs-stdlib/pull/731
# Stdlib::Compat::Ipv6 $network,
String $network,
Stdlib::IP::Address::V6 $network,
Integer $prefix,
String $range = '',
String $range_temp = '',
Expand Down
2 changes: 1 addition & 1 deletion metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"dependencies": [
{
"name": "puppetlabs/stdlib",
"version_requirement": ">= 4.16.0 < 6.0.0"
"version_requirement": ">= 4.25.0 < 6.0.0"
},
{
"name": "puppetlabs/concat",
Expand Down