Normalise MAC addresses to upper case in dhcpd.host #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If dhcpd.host.erb normalises all MAC addresses into upper case then this makes duplicate MAC address detection easier. In our use case XenServer only notices MACs are duplicated if they are the same case so we want to ensure that everywhere MACs are used they are in upper case.
underscorgan
pushed a commit
that referenced
this pull request
Mar 31, 2015
Normalise MAC addresses to upper case in dhcpd.host
|
Great, thanks for the contribution @drt24 ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-dhcp
that referenced
this pull request
Jun 26, 2020
Normalise MAC addresses to upper case in dhcpd.host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dhcpd.host.erb normalises all MAC addresses into upper case then this makes duplicate MAC address detection easier.
In our use case XenServer only notices MACs are duplicated if they are the same case so we want to ensure that everywhere MACs are used they are in upper case.