Update based on voxpupuli/modulesync 0.16.3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2016
Open
dhoppe
changed the title
alexjfisher
reviewed
Dec 9, 2016
| @@ -92,12 +92,9 @@ | |||
| fail('cfg parameter must be a hash') | |||
| } | |||
|
|
|||
| anchor { 'grafana::begin': } -> | |||
There was a problem hiding this comment.
@dhoppe Great work on the modulesync PR. All looks good. This did stand out a bit though.
I thought perhaps we preferred contain over anchor?
ie like this
contain '::grafana::install'
contain '::grafana::config'
contain '::grafana::service'
Class['::grafana::install'] ->
Class['::grafana::config'] ~>
Class['::grafana::service']There was a problem hiding this comment.
Yes, but there is an issue regarding broken dependencies. According to metadata.json Puppet >= 3.2 is supported, but contains was added at Puppet 3.4. The issuer could not use this module anymore, because he still uses Puppet 3.2.
I think this will be fixed with a lot of other stuff during the migration to Puppet 4.
There was a problem hiding this comment.
yeah, ok, if you're doing a reporter of a bug a favour, then I don't have any big problem with it.
bastelfreak
pushed a commit
that referenced
this pull request
Apr 8, 2019
* initial commit + tests for grafana_folder type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be a lot of error messages I have to work on.