-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version, because 6.0.0-beta1 does not exist anymore #163
Conversation
@@ -104,8 +104,8 @@ | |||
'beta' => 'https://packages.grafana.com/oss/rpm-beta', | |||
} | |||
|
|||
yumrepo { 'grafana': | |||
descr => 'grafana repo', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to remove the old repo?
yumrepo { 'grafana':
ensure => absent,
}
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are probably right. I will fix this in the evening.
descr => 'grafana repo', | ||
ensure => 'absent', | ||
descr => 'grafana repo', | ||
before => Package[$::grafana::package_name], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not prefix variables with ::
after $
. that is legacy puppet3 syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be fixed, after #164 has been merged, because it will introduce the necessary lint check.
manifests/install.pp
Outdated
@@ -105,7 +105,13 @@ | |||
} | |||
|
|||
yumrepo { 'grafana': | |||
descr => 'grafana repo', | |||
ensure => 'absent', | |||
descr => 'grafana repo', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. descr
not needed.
Pull Request (PR) description
This is necessary to fix the Travis CI pipeline.
This Pull Request (PR) fixes the following issues
Fixes #160
Fixes #161
Fixes #162
Fixes #164