Fix version, because 6.0.0-beta1 does not exist anymore #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
reviewed
Mar 26, 2019
| @@ -104,8 +104,8 @@ | |||
| 'beta' => 'https://packages.grafana.com/oss/rpm-beta', | |||
| } | |||
|
|
|||
| yumrepo { 'grafana': | |||
| descr => 'grafana repo', | |||
There was a problem hiding this comment.
Do we need to remove the old repo?
yumrepo { 'grafana':
ensure => absent,
}??
There was a problem hiding this comment.
You are probably right. I will fix this in the evening.
bastelfreak
reviewed
Mar 26, 2019
| descr => 'grafana repo', | ||
| ensure => 'absent', | ||
| descr => 'grafana repo', | ||
| before => Package[$::grafana::package_name], |
There was a problem hiding this comment.
please do not prefix variables with :: after $. that is legacy puppet3 syntax
There was a problem hiding this comment.
This will be fixed, after #164 has been merged, because it will introduce the necessary lint check.
alexjfisher
approved these changes
Mar 26, 2019
manifests/install.pp
Outdated
| @@ -105,7 +105,13 @@ | |||
| } | |||
|
|
|||
| yumrepo { 'grafana': | |||
| descr => 'grafana repo', | |||
| ensure => 'absent', | |||
| descr => 'grafana repo', | |||
bastelfreak
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This is necessary to fix the Travis CI pipeline.
This Pull Request (PR) fixes the following issues
Fixes #160
Fixes #161
Fixes #162
Fixes #164