-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD 12 support #179
Conversation
We have everything to run this module on FreeBSD using pkg/repo install_method. It would be very nice to have this module available for FreeBSD users ( no need to mark it as supported platform in metadata.json ) Tested on: FreeBSD 12.0-RELEASE, FreeBSD 13-HEAD
Great work @olevole this needs FreeBSD added to the |
We have everything to run this module on FreeBSD using pkg/repo install_method. It would be very nice to have this module available for FreeBSD users ( no need to mark it as supported platform in metadata.json ) Tested on: FreeBSD 12.0-RELEASE, FreeBSD 13-HEAD
@ghoneycutt |
data/family/FreeBSD.yaml
Outdated
@@ -0,0 +1,7 @@ | |||
--- | |||
grafana::cfg_location: '/usr/local/etc/grafana.ini' | |||
grafana::data_dir: '/var/db/grafana', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment at the end isn't valid. If you remove it, the tests might pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my bad. Thanks!
Can you please take a look at the failing travis jobs? |
added dependency for x11-fonts/fontconfig
@@ -143,6 +150,11 @@ | |||
name => $grafana::package_name, | |||
} | |||
} | |||
'FreeBSD': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this package required? It doesn't sound like anything grafana specific. Is the FreeBSD package for grafana lacking a dependency? If this is a generic package, it might be already managed by other modules which results in a duplicate resource error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the dependency already exists in the package. I just duplicated the previous entries (other distributions have no valid dependencies in grafana? I'll fix it now
official repository from the Grafana project does not exist for FreeBSD. Therefore, we use a common FreeBSD project repository.
@bastelfreak Thank you very much! |
We have everything to run this module on FreeBSD
using pkg/repo install_method.
It would be very nice to have this module available
for FreeBSD users ( no need to mark it as supported platform
in metadata.json )
Tested on: FreeBSD 12.0-RELEASE, FreeBSD 13-HEAD
Pull Request (PR) description
This Pull Request (PR) fixes the following issues