-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for teams, dashboard permissions and memberships #210
Conversation
In order to be able to manage organizations properly, they should be able to be deleted as well as created. To make things predictable, the default organization cannot be modified.
Dear @DavidReubenWhite, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I'm not custom type/provider expert. I will leave this open for a few days in case somebody else want's to review as well.
LGTM Adding a few acceptance tests would ensure that this does not become brittle in the future. |
This pull request addresses the following concerns:
teams
Currently there is no support in this module for managing teams within an organization. Have added this type. Allows the home dashboard for team to be set / updated also.
organizations
To bring orgs in line with other resources - have updated this type so that orgs can be deleted. Couple of caveats to ensure predictability - default org "mainOrg." cannot be modified and if an organization is deleted, the orgnanization in use is returned to the default org.
dashboard permissions
I see another merge just now where the folder permissions were set on the folder itself. I am open to redoing the permissions as properties on a dashboard but I feel having permissions as a different type is easier to use and saves having to use hashes.
Able to set permissions on a dashboard for either a user or a team. Once permissions are set, the default permissions on a dashboard are removed. Otherwise this defeats the point of setting permissions per team/user.
memberships
This is the concept of a user belonging to an organization or a team.
autorequires
Due to the reliance on some of these types on other types being defined prior, these new types have autorequires to ensure ordering is done properly without the end user having to do it. As long as the resources specified in the parameters are present - it will work.