Fix grafana_user password idempotency

lib/puppet/provider/grafana_user/grafana.rb

@@ -82,7 +82,7 @@ def theme=(value)
   end
 
   def password
-    user[:password]
+    nil
   end
 
   def password=(value)
@@ -126,6 +126,24 @@ def save_user
     self.user = nil
   end
 
+  def check_password
+    uri = URI.parse format('%s://%s:%d%s/dashboards/home', grafana_scheme, grafana_host, grafana_port, resource[:grafana_api_path])
+    request = Net::HTTP::Get.new(uri.to_s)
+    request.content_type = 'application/json'
+    request.basic_auth resource[:name], resource[:password]
+    response = Net::HTTP.start(grafana_host, grafana_port,
+                               use_ssl: grafana_scheme == 'https',
+                               verify_mode: OpenSSL::SSL::VERIFY_NONE) do |http|
+      http.request(request)
+    end
+
+    if response.code == '200'
+      true
+    else
+      false
+    end
+  end
+
   def delete_user
     response = send_request('DELETE', format('%s/admin/users/%s', resource[:grafana_api_path], user[:id]))
 

lib/puppet/type/grafana_user.rb

@@ -43,6 +43,9 @@
 
   newproperty(:password) do
     desc 'The password for the user'
+    def insync?(_is)
+      provider.check_password
+    end
   end
 
   newproperty(:email) do

spec/acceptance/grafana_user_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper_acceptance'
+
+describe 'grafana_user' do
+  context 'setup grafana server' do
+    it 'runs successfully' do
+      pp = <<-EOS
+      class { 'grafana':
+        cfg => {
+          security => {
+            admin_user     => 'admin',
+            admin_password => 'admin'
+          }
+        }
+      }
+      EOS
+      apply_manifest(pp, catch_failures: true)
+      apply_manifest(pp, catch_changes: true)
+    end
+  end
+  it 'runs successfully' do
+    pp = <<-EOS
+
+    grafana_user { 'user1':
+      grafana_url       => 'http://localhost:3000',
+      grafana_user      => 'admin',
+      grafana_password  => 'admin',
+      full_name         => 'John Doe',
+      password          => 'Us3r5ecret',
+      email             => 'john@example.com',
+    }
+    EOS
+    apply_manifest(pp, catch_failures: true)
+    apply_manifest(pp, catch_changes: true)
+  end
+end