Fix default PGP key #308
Merged
Fix default PGP key #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
commented
Feb 3, 2023
| @@ -53,7 +53,7 @@ | |||
| # Defaults to https://packages.grafana.com/gpg.key. | |||
| # | |||
| # @param repo_key_id When using 'repo' install_method, the repo_key_id of the repo_gpg_key_url key on Debian based systems. | |||
| # Defaults to 4E40DDF6D76E284A4A6780E48C8C34C524098CB6. | |||
| # Defaults to 0E22EB88E39E12277A7760AE9E439B102CF3C0C6. | |||
There was a problem hiding this comment.
The default value should be read from the actual code, for now just update it: there is a lot of parameter that read a value from data/common.yaml and these default parameters should be moved around in another PR.
|
So Debian CI fails because the Grafana repos are broken (metadata reference a package version that is not available, maybe transcient), Ubuntu CI fails because it needs the same breakage as Debian, and CentOS 8 CI fails because CentOS sucks. EVERYTHING IS FINE! It least I could check this successfully in the real world! Ready for review! |
According to https://packages.grafana.com/: > The GPG key used to sign the APT repository (fingerprint > 4E40DDF6D76E284A4A6780E48C8C34C524098CB6) was rotated on 2023-01-12 and > replaced with a new key with fingerprint > 0E22EB88E39E12277A7760AE9E439B102CF3C0C6. Update the key accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://packages.grafana.com/:
Update the key accordingly.