Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to grafana-cli in manifests/plugin.pp. #57

Closed
wants to merge 1 commit into from

Conversation

go8ose
Copy link

@go8ose go8ose commented Sep 19, 2017

On my Debian 8 system the grafana package has grafana-cli under /usr/sbin,
not /usr/bin. I don't have any experience with grafana, so I don't know if this is something that never worked, or if the grafana packaging has changed at some point.

On my Debian 8 system the grafana package has grafana-cli under /usr/sbin,
not /usr/bin.
@wyardley
Copy link

It's in /usr/sbin on the one system (CentOS 7) I checked too. But I don't think this fix is safe; at a minimum, should just set an explicit PATH for the exec (including both directories), and then reference the command without the full path in the cmd line.

But I think the better fix is to rework this to use types / providers; I'll take a stab at it.

@wyardley
Copy link

#63

@wyardley
Copy link

Thanks for the contribution; closing this one via #63, though.

@wyardley wyardley closed this Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants