Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand organization property for dashboards #94

Merged
merged 2 commits into from
Mar 5, 2018

Conversation

brandonrdn
Copy link

For request #48 "add organization param to grafana_dashboard resource".

Also fixes syntax error where 'org_name' was used instead of 'organization' in the README

@bastelfreak
Copy link
Member

Hi @brandonrdn, thanks for the PR! Can you add a test for it? Did you test it locally?

@bastelfreak bastelfreak added the enhancement New feature or request label Mar 1, 2018
@brandonrdn
Copy link
Author

@bastelfreak I copied what was working for datasources over to dashboards, it was just a step to switch the organization before saving the dashboard. The issue we're having now is that it won't switch organizations at all (since the grafana_api_path update). I believe the way everything is written currently is broken. I've fixed part of it but am still getting some errors when creating datasources and dashboards, mostly already exists errors. So I'm making some adjustments and testing, then I'll probably push up a universal fix for all providers. Sorry for the late response, was out all last week.

@brandonrdn
Copy link
Author

@bastelfreak The recent push should fix the bug for organizations. I did some cleanup and changed some code around, but I verified through local testing that I was able to do the following:

  • Create 2 new organizations
  • Create 2 datasources on each organization (3 total orgs including default)
  • Create 2 dashborads on each organization

@bastelfreak
Copy link
Member

Thanks for the patch!

@bastelfreak bastelfreak merged commit 5e1203e into voxpupuli:master Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants