Accepts SHA1 and SHA256 fingerprint digests #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the documentation and examples should be updated to use SHA256 instead of SHA1, too. Whoever takes a look at the docs to set up a new cluster or node will probably use the latest Icinga2 release. |
The hash algorithm was changed from SHA1 to SHA256 with Icinga2 release 2.12.0. The type definition must accept both variants.
thorstenk
force-pushed
the
feature/flexible_fingerprint_digests
branch
from
ccbcf39
to
4264cdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash algorithm was changed from SHA1 to SHA256 with Icinga2 release
2.12.0. The type definition must accept both variants.
Fixes #631