Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong name o f attribute ssl_enable for influxdb2 #719

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

Scnaeg
Copy link
Contributor

@Scnaeg Scnaeg commented Jan 12, 2023

Otherwise Icinga2 will fail to start:

root@blablabl:~# systemctl status icinga2
× icinga2.service - Icinga host/service/network monitoring system
     Loaded: loaded (/lib/systemd/system/icinga2.service; enabled; vendor preset: enabled)
    Drop-In: /etc/systemd/system/icinga2.service.d
             └─limits.conf
     Active: failed (Result: exit-code) since Thu 2023-01-12 08:03:02 UTC; 30s ago
    Process: 2153039 ExecStartPre=/usr/lib/icinga2/prepare-dirs /etc/default/icinga2 (code=exited, status=0/SUCCESS)
    Process: 2153044 ExecStart=/usr/sbin/icinga2 daemon --close-stdio -e ${ICINGA2_ERROR_LOG} (code=exited, status=1/FAILURE)
  Main PID: 2153044 (code=exited, status=1/FAILURE)
     Status: "Config validation failed."
        CPU: 128ms

Jan 12 08:03:02 blablabl icinga2[2153086]: /etc/icinga2/features-enabled/influxdb2.conf(23):   enable_send_metadata = true
Jan 12 08:03:02 blablabl icinga2[2153086]: /etc/icinga2/features-enabled/influxdb2.conf(24):   enable_ssl = true
Jan 12 08:03:02 blablabl icinga2[2153086]:                                                     ^^^^^^^^^^^^^^^^^
Jan 12 08:03:02 blablabl icinga2[2153086]: /etc/icinga2/features-enabled/influxdb2.conf(25):   ssl_ca_cert = "/etc/ssl/certs/ca.cer"
Jan 12 08:03:02 blablabl icinga2[2153086]: /etc/icinga2/features-enabled/influxdb2.conf(26):   ssl_cert = "/etc/ssl/certs/blablabl.full.cer"
Jan 12 08:03:02 blablabl icinga2[2153086]: [2023-01-12 08:03:02 +0000] critical/config: 1 error
Jan 12 08:03:02 blablabl icinga2[2153086]: [2023-01-12 08:03:02 +0000] critical/cli: Config validation failed. Re-run with 'icinga2 daemon -C' after fixing the config.
Jan 12 08:03:02 blablabl systemd[1]: icinga2.service: Main process exited, code=exited, status=1/FAILURE
Jan 12 08:03:02 blablabl systemd[1]: icinga2.service: Failed with result 'exit-code'.
Jan 12 08:03:02 blablabl systemd[1]: Failed to start Icinga host/service/network monitoring system.

Otherwise Icinga2 will fail to start:
```
root@blablabl:~# systemctl status icinga2
× icinga2.service - Icinga host/service/network monitoring system
     Loaded: loaded (/lib/systemd/system/icinga2.service; enabled; vendor preset: enabled)
    Drop-In: /etc/systemd/system/icinga2.service.d
             └─limits.conf
     Active: failed (Result: exit-code) since Thu 2023-01-12 08:03:02 UTC; 30s ago
    Process: 2153039 ExecStartPre=/usr/lib/icinga2/prepare-dirs /etc/default/icinga2 (code=exited, status=0/SUCCESS)
    Process: 2153044 ExecStart=/usr/sbin/icinga2 daemon --close-stdio -e ${ICINGA2_ERROR_LOG} (code=exited, status=1/FAILURE)
  Main PID: 2153044 (code=exited, status=1/FAILURE)
     Status: "Config validation failed."
        CPU: 128ms

Jan 12 08:03:02 blablabl icinga2[2153086]: /etc/icinga2/features-enabled/influxdb2.conf(23):   enable_send_metadata = true
Jan 12 08:03:02 blablabl icinga2[2153086]: /etc/icinga2/features-enabled/influxdb2.conf(24):   enable_ssl = true
Jan 12 08:03:02 blablabl icinga2[2153086]:                                                     ^^^^^^^^^^^^^^^^^
Jan 12 08:03:02 blablabl icinga2[2153086]: /etc/icinga2/features-enabled/influxdb2.conf(25):   ssl_ca_cert = "/etc/ssl/certs/ca.cer"
Jan 12 08:03:02 blablabl icinga2[2153086]: /etc/icinga2/features-enabled/influxdb2.conf(26):   ssl_cert = "/etc/ssl/certs/blablabl.full.cer"
Jan 12 08:03:02 blablabl icinga2[2153086]: [2023-01-12 08:03:02 +0000] critical/config: 1 error
Jan 12 08:03:02 blablabl icinga2[2153086]: [2023-01-12 08:03:02 +0000] critical/cli: Config validation failed. Re-run with 'icinga2 daemon -C' after fixing the config.
Jan 12 08:03:02 blablabl systemd[1]: icinga2.service: Main process exited, code=exited, status=1/FAILURE
Jan 12 08:03:02 blablabl systemd[1]: icinga2.service: Failed with result 'exit-code'.
Jan 12 08:03:02 blablabl systemd[1]: Failed to start Icinga host/service/network monitoring system.
```
@cla-bot
Copy link

cla-bot bot commented Jan 12, 2023

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @Scnaeg

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@lbetz lbetz self-requested a review January 12, 2023 09:14
@lbetz lbetz added the bug label Jan 12, 2023
@lbetz lbetz added this to the v3.5.3 milestone Jan 12, 2023
@lbetz lbetz changed the title Fix InfluxDB 2 SSL enable attribute name fix wrong name o f attribute ssl_enable for influxdb2 Jan 12, 2023
@lbetz lbetz merged commit f68d461 into voxpupuli:master Jan 12, 2023
@Scnaeg Scnaeg deleted the influxdb2_ssl_enable_attribute_name branch January 12, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants