cli option broken w/ jenkins 1.563 on ubuntu precise

[nicobrevin]

Using a simple manifest like:

class { 'jenkins':
    cli                => true,
}

I get

err: /Stage[main]/Jenkins::Cli/Exec[jenkins-cli]/returns: change from notrun to 0 failed: unzip /usr/lib/jenkins/jenkins.war WEB-INF/jenkins-cli.jar && mv WEB-INF/jenkins-cli.jar /usr/lib/jenkins/jenkins-cli.jar && rm -rf WEB-INF returned 9 instead of one of [0] at /tmp/vagrant-puppet/modules-0/jenkins/manifests/cli.pp:22

And it looks like this is because the war is in a different location (/usr/share/jenkins).

Package information:

vagrant@tcomdigi-jenkins:/var/lib/jenkins$ apt-cache policy jenkins
jenkins:
  Installed: 1.563
  Candidate: 1.563
  Version table:
 *** 1.563 0
        500 http://pkg.jenkins-ci.org/debian/ binary/ Packages
        100 /var/lib/dpkg/status

I'll see if I can come up with a patch for you.

[nicobrevin]

This fixes it for me

https://gist.github.com/nicobrevin/9b01b1b5a36859158217

Like it says in the patch, it needs a version constraint, as I'm guessing this change was introduced between when the module was written and now. I couldn't see where this happened on the changelog - http://jenkins-ci.org/changelog