add download option to jenkins module #1047
Conversation
| @@ -56,6 +59,7 @@ | |||
| Boolean $enabled = true, | |||
| String $digest_type = 'sha1', | |||
| Boolean $pin = false, | |||
| Array $download_options = ['--http1.1'], | |||
There was a problem hiding this comment.
Should this really be the default?
There was a problem hiding this comment.
Actually the error is depending on which server behind update.jenins.io is serving the request. I think there is no downside for now to always use http1.1 instead of 2.0?
There was a problem hiding this comment.
HTTP 2.0 can be more efficient. Have you at least filed an issue with Jenkins to track it? IMHO such a workaround always needs an issue and link it in a code comment.
There was a problem hiding this comment.
No, there are a few servers behind and one of them is randomly having issues. i still haven't found out which server.
For me it will also be fine to remove the default but make it injectable via parameter so i can override it.
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok, that certainly helps in giving me assurances that this is the right thing to do.
There was a problem hiding this comment.
Well so there is the question if i make this exposing to for example jenkins::params::plugin_download_options ?
And why the heck are the tests failing since ages?
There was a problem hiding this comment.
And why the heck are the tests failing since ages?
It has been very hard to keep them green, mostly because we don't have proper dependency resolution. Ideally we'd have something that utilizes https://github.com/jenkinsci/plugin-installation-manager-tool/ so you don't need to do that yourself.
There was a problem hiding this comment.
As i can see in the documentation, the tool also won't resolve dependencies for you :(
For me my current plugin setup looks like this for latest debian version: (snippet)
It's a mess ..
manifests/job.pp
Outdated
| @@ -13,7 +13,7 @@ | |||
| define jenkins::job ( | |||
| String $config, | |||
| Optional[String] $source = undef, | |||
| Optional[Stdlib::Absolutepath] $template = undef, | |||
| Optional[String] $template = undef, | |||
There was a problem hiding this comment.
Could you submit this as a separate PR?
update gpg key file
new gpg key id
|
I'm sorry I missed the rebase, and now there's another conflict. I'm also running into this, so I opened #1073 as a clean rebase with a better commit message. |
|
#1073 was merged |
While on Debian10 plugin installation very often fails with:
Error: /Stage[main]/Jenkins::Plugins/Jenkins::Plugin[conditional-buildstep]/Archive[conditional-buildstep.hpi]/ensure: change from 'absent' to 'present' failed: Execution of '/usr/bin/curl https://updates.jenkins.io/latest/conditional-buildstep.hpi -o /tmp/conditional-buildstep.hpi_20220728-1598563-1n3z4vb -fsSLg --max-redirs 5' returned 16: curl: (16) Error in the HTTP2 framing layeri added http1.1 hard as download option to prevent those errors.