Support updates for core jenkins modules

[natewarr]

This fixes #118 and will (should) not break existing configurations. If the extension of the updated module is '.jpi', then put a .pinned file in the plugins folder before installing the updated module.

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[rtyler]

@natewarr Thanks for the code, I'll have to take a look at this on the weekend when I have a chance to write some more tests for it

[natewarr]

@rtyler Thanks for all of your hard work. Let me know how I might help further.

[rtyler]

@natewarr If you're not opposed to learning some rspec-puppet you could add some test cases yourself :)

[natewarr]

@rtyler I had a feeling you might say that. It doesn't look like I'll be able to beat you to it for this one.

[jchristi]

@natewarr per your comment on #118, I don't see how this is limited to .jpi files. From the Jenkins plugin tutorial: Create an empty file called <plugin>.hpi.pinned - e.g. maven-plugin.hpi.pinned. Is there something I'm missing?

[jchristi]

I updated the spec tests: 9d8930b

[natewarr]

My assumption is that .jpi means that the plugin is core and needs a .pinned. If its .hpi it doesn't need a pinned file. If my assumption is correct, the doc you reference is dated. I could just as easily be wrong.

[jchristi]

Just did a quick check and here are the plugins with jpi files:

$ ls -la /var/lib/jenkins/plugins/*.jpi | awk '{print $9}'
/var/lib/jenkins/plugins/ant.jpi
/var/lib/jenkins/plugins/credentials.jpi
/var/lib/jenkins/plugins/cvs.jpi
/var/lib/jenkins/plugins/external-monitor-job.jpi
/var/lib/jenkins/plugins/javadoc.jpi
/var/lib/jenkins/plugins/ldap.jpi
/var/lib/jenkins/plugins/mailer.jpi
/var/lib/jenkins/plugins/maven-plugin.jpi
/var/lib/jenkins/plugins/pam-auth.jpi
/var/lib/jenkins/plugins/ssh-credentials.jpi
/var/lib/jenkins/plugins/ssh-slaves.jpi
/var/lib/jenkins/plugins/subversion.jpi
/var/lib/jenkins/plugins/translation.jpi

Those look like core plugins to me but its been awhile since I've messed with Jenkins so I don't know if its exhaustive. Question about the .pinned file though...if you add a .pinned file, then later update your puppet config to a newer version, won't the .pinned file prevent that from happening?

[jchristi]

I think you're right, this seems to confirm that. I checked my installation and only core plugins can be pinned. Adding a ".pinned" file basically places the plugin under manual user control rather than being locked and controlled by Jenkins.

[natewarr]

@rtyler Let me know if/when you want to do some hacking at puppetconf. Cheers.

[natewarr]

I fixed the auto-merge issue with the upstream code and smashed the commits down to one.

[rtyler]

This has been merged out of band from GItHub and is in the head of master