Support configuring a yum proxy server #328
Conversation
this allows installing jenkins via yum behind a proxy server.
| if $yum_proxy { | ||
| Yumrepo['jenkins'] { | ||
| proxy => $yum_proxy, | ||
| } |
There was a problem hiding this comment.
Does this need to be done as a resource default? I feel that they are somewhat of an anti-pattern until if/when the scope is restricted. I've battled endless problems with defaults leaking out and causing unintended side-effects.
There was a problem hiding this comment.
not necessarily. this was the first solution that came to my mind without thinking to much about it...
i could move the proxy parameter directly to the yumrepo resource declarations. should we keep 'undef' for the default case or should we convert the parameter to 'absent' in el.pp?
i was also thinking about the name 'yum_proxy'. maybe we should call it 'repo_proxy' as this could also be used for apt and zypper repos.
thanks for your feedback
There was a problem hiding this comment.
repo_proxy might be a bit better long term since fedora 22 has replaced yum with dnf.
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
as this parameter could also be used for apt or zypper
instead of using a resource ref move the proxy parameter directly to the yumrepo resources as suggested by @jhoblitt.
Support configuring a yum proxy server
This pull request adds a new parameter yum_proxy to init.pp. It's used in repo/el.pp to configure the jenkins yum repository with a proxy server.
This allows installing jenkins via yum behind a proxy server.