Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring a yum proxy server #328

Merged
merged 7 commits into from
Jun 26, 2015
Merged

Support configuring a yum proxy server #328

merged 7 commits into from
Jun 26, 2015

Conversation

tosmi
Copy link
Contributor

@tosmi tosmi commented Jun 24, 2015

This pull request adds a new parameter yum_proxy to init.pp. It's used in repo/el.pp to configure the jenkins yum repository with a proxy server.

This allows installing jenkins via yum behind a proxy server.

if $yum_proxy {
Yumrepo['jenkins'] {
proxy => $yum_proxy,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be done as a resource default? I feel that they are somewhat of an anti-pattern until if/when the scope is restricted. I've battled endless problems with defaults leaking out and causing unintended side-effects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily. this was the first solution that came to my mind without thinking to much about it...

i could move the proxy parameter directly to the yumrepo resource declarations. should we keep 'undef' for the default case or should we convert the parameter to 'absent' in el.pp?

i was also thinking about the name 'yum_proxy'. maybe we should call it 'repo_proxy' as this could also be used for apt and zypper repos.

thanks for your feedback

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repo_proxy might be a bit better long term since fedora 22 has replaced yum with dnf.

@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

as this parameter could also be used for apt or zypper
instead of using a resource ref move the proxy parameter directly to
the yumrepo resources as suggested by @jhoblitt.
@rtyler rtyler added this to the 1.5.0 - Jennings milestone Jun 26, 2015
rtyler pushed a commit that referenced this pull request Jun 26, 2015
Support configuring a yum proxy server
@rtyler rtyler merged commit a8c0658 into voxpupuli:master Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants