-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to setup LDAP auth #339
Conversation
Be able to setup LDAP auth on Jenkins master. This resulted in splitting set security method into three methods for setting: - ldap auth - password auth - unsecured Also give a chance to turn on the slave to master feature during deployment.
$jenkins_s2m_acl = false, | ||
$jenkins_ssh_private_key_contents = '', | ||
$jenkins_ssh_public_key_contents = '', | ||
$ldap_access_group = '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge amount of parameters for the jenkins::security class. I suggest changing this to take a hash called ldap_config
. You could even set the defaults in a container class like jenkins::ldap::config
or something like that.
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Moved ldap params into jenkins::ldap::config. Moved ssh private/public keys into cli_helper, since its related to the cli invocation.
@mescanef My work to support configuring the security realm and authentication strategy via native types was merged in #382. Do you think this work could be merge with the groovy |
Any news on this PR? |
@rhoml At a minimum it needs to be rebased on the current master and I think it should be converted to passing json instead of CLI args. I think it would be less work to add this to the |
Hello everybody. I'm going to close this PR due to inactivity. Please reopen and rebase the PR if anybody is still interested in it. |
Be able to setup LDAP auth on Jenkins master. This resulted in splitting
set security method into three methods for setting:
ldap auth
password auth
unsecured
Also give choice to turn on the slave to master feature during
deployment.