Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate db, dbtype, and dbdriver #73

Closed
tedivm opened this issue Apr 22, 2015 · 3 comments · Fixed by #256
Closed

consolidate db, dbtype, and dbdriver #73

tedivm opened this issue Apr 22, 2015 · 3 comments · Fixed by #256

Comments

@tedivm
Copy link

tedivm commented Apr 22, 2015

Right now you have to set three configs in order to accomplish the switching between one database type and another. I think it makes far more sense to change the dbtype and dbdriver values based off of what people set for db.
@tedivm tedivm changed the title db, dbtype, and dbdriver consolidate db, dbtype, and dbdriver Apr 22, 2015
@mkrakowitzer
Copy link
Contributor

+1, agree 100%

@nathonfowlie
Copy link

Another up vote for this one. I only skimmed through the documentation and was quite confused when it was defaulting to Postgres despite the fact I'd set dbtype and dbdriver. Would be good to pivot off the "dbtype" setting to select the appropriate driver and default port (but keep the dbport option for non-standard configurations).

@TJM
Copy link
Contributor

TJM commented Jun 29, 2018

Agreed, make the defaults undef then when its being used, test if its undef, and use a reasonable default based on $jira::db (which seems to be the switch for other parameters)

TJM added a commit to TJM/puppet-jira that referenced this issue Jul 3, 2018
@TJM
Fix voxpupuli#254 Add Support for H2 Database (for testing)
cea227a 
Also Fix voxpupuli#73 - Set appropriate defaults for dbtype and dbdriver based on db.
TJM added a commit to TJM/puppet-jira that referenced this issue Jul 3, 2018
@TJM
Fix voxpupuli#254 Add Support for H2 Database (for testing)Also Fix v…
724c96c 
…oxpupuli#73 - Set appropriate defaults for dbtype and dbdriver based on db.
@TJM TJM mentioned this issue Jul 3, 2018
Merged
TJM added a commit to TJM/puppet-jira that referenced this issue Jul 5, 2018
@TJM
Fix voxpupuli#254 Add Support for H2 Database
8b786c7 
Also Fix voxpupuli#73 - Set appropriate defaults for dbtype and dbdriver based on db.
TJM added a commit to TJM/puppet-jira that referenced this issue Jul 5, 2018
@TJM
Fix voxpupuli#73 MySQL test default port should be 3306
ccd5107
bastelfreak added a commit that referenced this issue Jul 9, 2018
@bastelfreak
Merge pull request #256 from TJM/issue_254_h2
425533e 
Add Support for H2 Database and Fix #73
cegeka-jenkins pushed a commit to cegeka/puppet-jira that referenced this issue Oct 13, 2021
@TJM
Fix voxpupuli#254 Add Support for H2 Database
9d5dec2 
Also Fix voxpupuli#73 - Set appropriate defaults for dbtype and dbdriver based on db.
cegeka-jenkins pushed a commit to cegeka/puppet-jira that referenced this issue Oct 13, 2021
@TJM
Fix voxpupuli#73 MySQL test default port should be 3306
0c65fc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Support for H2 Database and Fix #73 TJM/puppet-jira
4 participants
@tedivm @mkrakowitzer @TJM @nathonfowlie