Add newer OSes and Puppet 7 to test matrix, drop Puppet 5 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oranenj
force-pushed
the
test-with-new-stuff
branch
from
9652ac4
to
d9605bd
Compare
|
I think the test setup has locale trouble. There's a line where it fails to set the locale and defaults to C, and then: |
|
Testing by myself in a CentOS 7 VM, Puppet 7 works fine. This test failure is bogus :/ |
oranenj
force-pushed
the
test-with-new-stuff
branch
from
2015bbd
to
b856624
Compare
|
Tests work if locale is forced to en_US.UTF-8 |
|
@bastelfreak any idea what to do about the locale thing? Seems to require changes in modulesync... :/ |
but it's not this module's fault
oranenj
force-pushed
the
test-with-new-stuff
branch
from
795fddc
to
94298ee
Compare
oranenj
changed the title
bastelfreak
approved these changes
Apr 20, 2021
|
Merging with the locale hack for now, submitted a PR to modulesync about it |
ekohl
reviewed
May 31, 2021
Comment on lines
+74
to
+77
| # Yes, this should be in modulesync, but for now, just work around weird test failures | ||
| # caused by locale on CentOS 7 with Puppet 7 | ||
| LANG: en_US | ||
| LC_ALL: en_US.UTF-8 |
There was a problem hiding this comment.
voxpupuli/modulesync_config#708 has more context. Linking to cross-reference.
cegeka-jenkins
pushed a commit
to cegeka/puppet-jira
that referenced
this pull request
Oct 13, 2021
Add newer OSes and Puppet 7 to test matrix, drop Puppet 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see what the tests say about this. Fixes #361