Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom plugin installation and usage of JNDI database connections #389

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Allow custom plugin installation and usage of JNDI database connections #389

merged 1 commit into from
Nov 25, 2021

Conversation

ThomasMinor
Copy link
Contributor

Pull Request (PR) description

Added feature to install custom plugins and use JNDI database connections

This Pull Request (PR) fixes the following issues

n/a

root-expert
root-expert requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for your conribution!

Take a look at the inline comments I left. If you need any help you can contact us on the #voxpupuli channel on Libera.Chat IRC or on Puppet's Slack (same channel)

manifests/init.pp Outdated Show resolved Hide resolved
spec/spec_helper.rb Outdated Show resolved Hide resolved
@ThomasMinor
Copy link
Contributor Author

Hi there, does anyone have a hint how to eliminate the one failing test on CentOS 7? Maybe a good document about running the tests locally?

@kenyon
Copy link
Member

kenyon commented Nov 24, 2021

Hi there, does anyone have a hint how to eliminate the one failing test on CentOS 7? Maybe a good document about running the tests locally?

Docs on running tests can be found here: https://github.com/voxpupuli/puppet-jira/blob/master/.github/CONTRIBUTING.md

@root-expert
Copy link
Member

Hey @ThomasMinor took a look at the output of the tests. Sadly we have seen this error before. The current workaround is to add these 2 lines in our pipeline.

@ThomasMinor
Copy link
Contributor Author

Hi @root-expert, I followed your advice to add the workaround and the tests succeeded - Thanks!
I just have a few questions now...

  • How did You identified the LANG settings as the cause of the problem from the logged messages?
  • Isn't isn't it a bad idea to modify the ci.yml file due to the modulesync management?

@root-expert
Copy link
Member

  • How did You identified the LANG settings as the cause of the problem from the logged messages?

The error was Error: /Stage[main]/Postgresql::Server::Reload/Exec[postgresql_reload]: invalid byte sequence in US-ASCII

bastelfreak had deployed that workaround in the past for puppet-zabbix so it was known to me 😄

  • Isn't isn't it a bad idea to modify the ci.yml file due to the modulesync management?

Yes it will be overwritten, we manually add it back when we are modulesyncing.
There's some discussion here regarding the issue btw.

root-expert
root-expert approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a user of the module but seems okay to me

@root-expert root-expert changed the title Custom plugin installation Allow custom plugin installation Nov 25, 2021
@root-expert root-expert added the enhancement New feature or request label Nov 25, 2021
@root-expert
Copy link
Member

Can you squash you commits before merging?

@root-expert root-expert changed the title Allow custom plugin installation Allow custom plugin installation and usage of JNDI database connections Nov 25, 2021
@root-expert root-expert merged commit f2f8915 into voxpupuli:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@root-expert root-expert root-expert approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasMinor @kenyon @root-expert @bastelfreak