Drop reverse and always require Puppet 4+ style and Ruby 2.1 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gemnasium has been inoperational for some time and can be removed.
While this will still work with older versions, this lint check is only intended for Puppet 4 and newer Ruby 2.1 is safe to assume.
Puppet 3 is dead and our manifests should be written in the modern style.
alexjfisher
reviewed
Nov 28, 2019
| @@ -3,5 +3,5 @@ source 'https://rubygems.org' | |||
| gemspec | |||
|
|
|||
| group :release do | |||
| gem 'github_changelog_generator', :require => false, :git => 'https://github.com/github-changelog-generator/github-changelog-generator' if RUBY_VERSION >= '2.2.2' | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Since this is so rarely released and it usually works on small modules I'd like to avoid it. Especially since this is not managed in any way.
|
Looks like this repo needs a label sync |
alexjfisher
approved these changes
Dec 5, 2019
|
Synced the labels and added backwards-incompatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet 3 is dead and our manifests should be written in the modern style.
While this will still work with older versions, this lint check is only intended for Puppet 4 and newer Ruby 2.1 is safe to assume.