MODULES-1192 fixes to handle mcollective::actionpolicy::rule 'facts' par... #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameter conflicting with $facts hash when trusted_node_data=true - add travis matrix builds for puppet 3.7.0, with and without trusted_node_data=true - rename mcollective::actionpolicy::rule 'facts' parameter to 'fact_filter', to not conflict with $facts hash from trusted_node_data=true - require puppetlabs_spec_helper >= 0.7.0 for TRUSTED_NODE_DATA env variable - add actionpolicy::rule spec, along with test for specified facts param - update templates/actionpolicy.erb
|
LGTM, would merge if someone agrees. |
igalic
added a commit
that referenced
this pull request
Sep 21, 2015
MODULES-1192 fixes to handle mcollective::actionpolicy::rule 'facts' par...
|
Given that we remove facts as parameter (although it never worked correctly): I guess so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ameter conflicting with $facts hash when trusted_node_data=true
This is a rebased & fixed PR for #161