fix redis implementation #350
Conversation
rwaffen
commented
Sep 28, 2017
rwaffen
commented
- add ddl from R.I.Pienaar for redis
- remove duplicated parameter from connector
- with out this mcollective service wont start with puppet-agent-1.10.5 one centos 7
| :author => "R.I.Pienaar <rip@devco.net>", | ||
| :license => "ASL 2.0", | ||
| :version => "1.0.0", | ||
| :url => "https://github.com/ripienaar/mcollective-vagrant", |
There was a problem hiding this comment.
Is this url correct? It does not seem to be related to the redis connector.
There was a problem hiding this comment.
I couldn't find another or "the" source, but the redis connector in both mcollective modules are the same. So the voxpupuli one and the one from https://github.com/ripienaar/mcollective-vagrant/tree/master/deploy/modules/mcollective/files/lib/connector are the same.
this is only a meta file, but i don't wanted to write my name in there, i only wanted it to work ;-)
|
Hi @rwaffen, thanks for this PR! Is it possible to add a simple unit test somehow for this change? (It is okay if not) |
|
i will check, if i'm able to write a test. I'm not used to write rspec tests for other things than puppet... |
|
hi there, i don't get this running with unit tests. sry for that. 😞 |
