-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debian 10 support #619
Conversation
1a8d6b4
to
b6f9f1f
Compare
7214862
to
55812dc
Compare
Signed-off-by: Christos Papageorgiou <christos.papageorgioy@gmail.com>
55812dc
to
29e3fef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a user of MongoDB so might be off, but defaulting to different sources depending just on the OS version does not feel good to me.
What do you think if we adjust this PR so that:
- it always default to install the OS vendored package by default (and fail if such package does not exist);
- the test suite checks that the catalog does not compile with the default settings (to have a clue if for some reason a package is made available in the future. That should never happen with Debian but the code might be copied for other OS);
- the test suite checks that with explicit values for mange_repo / version the thing works as expected (by reusing example groups?).
$version = fact('os.distro.codename') ? { # Debian 10 doesn't provide mongodb 3.6. | ||
'buster' => '4.4.8', | ||
default => undef | ||
}, | ||
$manage_package_repo = fact('os.distro.codename') ? { # Debian 10 doesn't provide mongodb packages. So manage it! | ||
'buster' => true, | ||
default => undef | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That mean that the same configuration on some nodes install the version packaged for the system by the OS vendor, and on other brings in a custom repository and version not supported by the OS vendor.
I would be more confident if we required the end user to set manage_package_repo and version explicitly and defaulting to what the OS recommend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is that for some OSes the module will work out of the box and for Debian 10/11 you'll need mongodb::globals
class as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But since Debian does not support MongoDB out of the box, that seems fair. Maybe I am the only one worried by this :-) Let's wait for other reviewers opinion about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! are you interested in adding debian 11 in another PR?
Νο Debian 11 packages from mongo as far as I saw :( |
Hello, I have also a question: I assumed, that - if I set cu denny |
Hello @linuxmail! if you want to achieve that, I assume you have to set Chris |
Pull Request (PR) description
Debian 10 doesn't provide mongodb packages, so we need to set
manage_package_repo
to true by default and install latest version supported by the module (4.4.8)This Pull Request (PR) fixes the following issues