-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCRAM-SHA-256 support #643
SCRAM-SHA-256 support #643
Conversation
cdf8b8f
to
20b627a
Compare
- auth_mechanism parameter for mongodb_user - use password instead of password_hash if SCRAM-SHA-256, because password digestion is on the server - insync is not verified for the password
20b627a
to
e6d8a53
Compare
e6d8a53
to
b042af0
Compare
GitHub drop support for git:// url a while ago.
Thanks, I added 2 commits to your branch to fix CI. I'll let MongoDB users review the PR and test that the feature works as expected. |
Thanks @smortex , I'm working on adding some spec to test if the authentication mechanism selection work as expected. |
c251895
to
18e6c8a
Compare
The version of MongoDB used in CI tests doesn't support SCRAM-SHA-256 (except for debian10 machines) |
The module seems to need some love : CI test against rather old OSes, at least Debian 9 should not be here and Debian 11 should :-) If you think some old stuff prevents you from working efficiently with this codebase, maybe it is okay to slash the legacy support? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People reported they where happily using this is the sister issue. If you are OK with this as it is, I am OK with it too.
Pull Request (PR) description
Add limited support for SCRAM-SHA-256 authentication mechanism.
Limited because we loose the ability to check if the password is insync when SCRAM-SHA-256 is used.
The password is no longer digested on the client.
The second commit add the possibility to force the update of the password manually with a boolean.
This Pull Request (PR) fixes the following issues
Fixes #597