-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min version_requirement for Puppet + deps #283
Conversation
{ "name": "puppetlabs/stdlib", "version_requirement": ">= 4.6.0 < 5.0.0" }, | ||
{ "name": "puppetlabs/apt", "version_requirement": ">= 2.1.0 < 3.0.0" }, | ||
{ "name": "puppetlabs/inifile", "version_requirement": ">=1.4.1 < 2.0.0" }, | ||
{ "name": "darin/zypprepo", "version_requirement": ">=1.0.2 < 2.0.0" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Puppet 4 release
{ "name": "puppetlabs/inifile", "version_requirement": ">=1.4.1 < 2.0.0" }, | ||
{ "name": "darin/zypprepo", "version_requirement": ">=1.0.2 < 2.0.0" }, | ||
{ "name": "puppet/archive", "version_requirement": ">= 1.0.0 < 2.0.0" }, | ||
{ "name": "example42/yum", "version_requirement": "2.1.28 < 3.0.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Puppet 4 release. Also see #284
Some of these are soft dependencies and not hard ones #285 |
{ "name": "puppetlabs/inifile", "version_requirement": ">=1.4.1 < 2.0.0" }, | ||
{ "name": "darin/zypprepo", "version_requirement": ">=1.0.2 < 2.0.0" }, | ||
{ "name": "puppet/archive", "version_requirement": ">= 1.0.0 < 2.0.0" }, | ||
{ "name": "example42/yum", "version_requirement": "2.1.28 < 3.0.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be >= 2.1.28?
We currently only run automated tests against Puppet 3 latest and therefore cannot guarantee that this module works as is expected with earlier Puppet versions Bump dependencies to the minimum version that should work under Puppet 4, based on the metadata Also remove deprecated pe version_requirement field
8e8c568
to
9898721
Compare
@bastelfreak fixed |
We currently only run automated tests against Puppet 3 latest and
therefore cannot guarantee that this module works as is expected with
earlier Puppet versions
Bump dependencies to the minimum version that should work under
Puppet 4, based on the metadata
Also remove deprecated pe version_requirement field