Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min version_requirement for Puppet + deps #283

Merged
merged 1 commit into from
Dec 26, 2016

Conversation

juniorsysadmin
Copy link
Member

We currently only run automated tests against Puppet 3 latest and
therefore cannot guarantee that this module works as is expected with
earlier Puppet versions

Bump dependencies to the minimum version that should work under
Puppet 4, based on the metadata

Also remove deprecated pe version_requirement field

{ "name": "puppetlabs/stdlib", "version_requirement": ">= 4.6.0 < 5.0.0" },
{ "name": "puppetlabs/apt", "version_requirement": ">= 2.1.0 < 3.0.0" },
{ "name": "puppetlabs/inifile", "version_requirement": ">=1.4.1 < 2.0.0" },
{ "name": "darin/zypprepo", "version_requirement": ">=1.0.2 < 2.0.0" },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Puppet 4 release

{ "name": "puppetlabs/inifile", "version_requirement": ">=1.4.1 < 2.0.0" },
{ "name": "darin/zypprepo", "version_requirement": ">=1.0.2 < 2.0.0" },
{ "name": "puppet/archive", "version_requirement": ">= 1.0.0 < 2.0.0" },
{ "name": "example42/yum", "version_requirement": "2.1.28 < 3.0.0" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Puppet 4 release. Also see #284

@juniorsysadmin
Copy link
Member Author

Some of these are soft dependencies and not hard ones #285

{ "name": "puppetlabs/inifile", "version_requirement": ">=1.4.1 < 2.0.0" },
{ "name": "darin/zypprepo", "version_requirement": ">=1.0.2 < 2.0.0" },
{ "name": "puppet/archive", "version_requirement": ">= 1.0.0 < 2.0.0" },
{ "name": "example42/yum", "version_requirement": "2.1.28 < 3.0.0" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be >= 2.1.28?

We currently only run automated tests against Puppet 3 latest and
therefore cannot guarantee that this module works as is expected with
earlier Puppet versions

Bump dependencies to the minimum version that should work under
Puppet 4, based on the metadata

Also remove deprecated pe version_requirement field
@juniorsysadmin
Copy link
Member Author

@bastelfreak fixed

@bastelfreak bastelfreak merged commit fef201f into voxpupuli:master Dec 26, 2016
@juniorsysadmin juniorsysadmin deleted the bumpdeps branch December 27, 2016 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants