Fixing wrong pear package name in Amazon Linux #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the pear package name is defined based on `$facter['os']['family']`. The problem is that Amazon Linux has 'RedHat' as os family.
I set an `if` before case searching for 'Amazon' in `$facter['os']['name']` based on the output of the facter command on Amazon instances:
```shell
$ facter os
{
architecture => "x86_64",
family => "RedHat",
hardware => "x86_64",
name => "Amazon",
release => {
full => "2017.09",
major => "2017",
minor => "09"
},
selinux => {
enabled => false
}
}
```
juniorsysadmin
approved these changes
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the pear package name is defined, it is based on
$facter['os']['family']. The problem is that Amazon Linux has 'RedHat' as os family.I set an
ifbefore case searching for 'Amazon' in$facter['os']['name']based on the output of the facter command on Amazon instances:$ facter os { architecture => "x86_64", family => "RedHat", hardware => "x86_64", name => "Amazon", release => { full => "2017.09", major => "2017", minor => "09" }, selinux => { enabled => false } }Extra information:
Puppet agent version: 4.10.1
facter version: 3.6.4
AMI Releas: Amazon Linux AMI 2017.09.0.20170930 x86_64 HVM EBS