Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP:Debian Mysql Extension Fix #432

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WIP:Debian Mysql Extension Fix #432

wants to merge 5 commits into from

Conversation

c33s
Copy link
Member

@c33s c33s commented Mar 18, 2018

based upon #322

bastelfreak
bastelfreak reviewed Mar 18, 2018
View reviewed changes
manifests/extension/config.pp
require => ::Php::Config[$title],
}

if $::php::fpm {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the trailing ::, while you are already refactoring? They are totally unneeded.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would suggest to do this (i can do it) in a seperate PR, i personally dislike having noisy diffs from style fixes together with logical changes.

@bastelfreak bastelfreak added bug Something isn't working needs-work not ready to merge just yet needs-tests labels Mar 18, 2018
@bastelfreak
Copy link
Member

Can you add a few tests or review the current ones so we can ensure that the new logic is correct?

@c33s
Copy link
Member Author

c33s commented Mar 18, 2018

trying to get the tests running locally.

fatal: cannot create directory at 'spec/vcr/GitHubChangelogGenerator_OctoFetcher/_fetch_closed_issues_and_pr/when_API_ca
ll_is_valid/returns_issue_with_proper_key': Filename too long

@c33s c33s changed the title Debian Mysql Extension Fix WIP:Debian Mysql Extension Fix Mar 18, 2018
@bastelfreak
Copy link
Member

The error and the paths look strange. Is this caused by this repo? Which command did you use?

@c33s c33s mentioned this pull request Mar 20, 2018
Closed
@c33s c33s mentioned this pull request Mar 21, 2018
Merged
@rgevaert
Copy link

I'm looking forward to see this completed. For now I see that some other PRs are also being worked on. I'm happy to test some things once things are getting stable.

@c33s c33s mentioned this pull request Dec 19, 2018
Closed
@vox-pupuli-tasks
Copy link

Dear @c33s, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @c33s, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @c33s, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

Assignees
No one assigned
Labels
bug Something isn't working merge-conflicts needs-rebase needs-tests needs-work not ready to merge just yet tests-fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c33s @bastelfreak @rgevaert @dhoppe