Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modulesync 2.5.1 and drop Puppet 4 #507

Merged
merged 3 commits into from
Feb 1, 2019
Merged

modulesync 2.5.1 and drop Puppet 4 #507

merged 3 commits into from
Feb 1, 2019

Conversation

bastelfreak
Copy link
Member

modulesync 2.5.1

- rvm: 2.4.4
bundler_args: --without system_tests development release
env: PUPPET_VERSION="~> 5.0" CHECK=test
- rvm: 2.5.1
- rvm: 2.5.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the latest release reverted ruby to 2.5.1 according to https://puppet.com/docs/puppet/6.2/about_agent.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panda_tableflip

I will check why this got reverted...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lulz, also realized this is a modulesync PR, so not the right place to address these changes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

na this is fine. Feedback is always welcome. I will merge this as is (if it turns green) and afterwards update modulesync_config repo.

Copy link
Member Author

@bastelfreak bastelfreak Feb 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to find a note about 2.5.1 in the changelog, nor a Jira issue. Also the latest rpm seems to include 2.5.3:

[root@4fb6828f1e15 /]# /opt/puppetlabs/puppet/bin/ruby -v
ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]
[root@4fb6828f1e15 /]# yum info puppet-agent
Loaded plugins: fastestmirror, ovl
Loading mirror speeds from cached hostfile
 * base: mirror.fra10.de.leaseweb.net
 * extras: mirror.ratiokontakt.de
 * updates: mirror.imt-systems.com
Installed Packages
Name        : puppet-agent
Arch        : x86_64
Version     : 6.2.0
Release     : 1.el7
Size        : 93 M
Repo        : installed
From repo   : puppet6
Summary     : The Puppet Agent package contains all of the elements needed to run puppet, including ruby, facter, and hiera.
URL         : https://www.puppetlabs.com
License     : See components
Description : The Puppet Agent package contains all of the elements needed to run puppet, including ruby, facter, and hiera.
            : 
            : Contains the following components:
            : cleanup
            : cpp-hocon 0.2.0
            : cpp-pcp-client 1.6.0
            : dmidecode 2.12
            : facter 3.12.3
            : hiera 3.5.0
            : leatherman 1.5.4
            : libwhereami 0.2.2
            : module-puppetlabs-augeas_core 1.0.1
            : module-puppetlabs-cron_core 1.0.0
            : module-puppetlabs-host_core 1.0.2
            : module-puppetlabs-mount_core 1.0.2
            : module-puppetlabs-scheduled_task 1.0.0
            : module-puppetlabs-selinux_core 1.0.1
            : module-puppetlabs-sshkeys_core 1.0.2
            : module-puppetlabs-yumrepo_core 1.0.3
            : module-puppetlabs-zfs_core 1.0.1
            : module-puppetlabs-zone_core 1.0.1
            : puppet 6.2.0
            : puppet-resource_api v1.6.3-7-g2419162
            : puppet-runtime 201901130
            : pxp-agent 1.10.4
            : runtime
            : shellpath 2015-09-18
            : virt-what 1.18
            : wrapper-script

[root@4fb6828f1e15 /]# /opt/puppetlabs/puppet/bin/openssl version
OpenSSL 1.1.1a  20 Nov 2018
[root@4fb6828f1e15 /]# 

I assume the docs are simply wrong. I will create an issue for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# THIS FILE IS MANAGED BY MODULESYNC

rm -f Gemfile.lock
if [ "${PUPPET_VERSION}" = '~> 4.0' ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're dropping version 4, no need for the conditional logic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove it in the next modulesync version (this is currently based on a template from https://github.com/voxpupuli/modulesync_config/tree/master/moduleroot )

task test: [
:metadata_lint,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is metadata_lint called from somewhere else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be included in the release_checks task

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -33,7 +33,7 @@
"requirements": [
{
"name": "puppet",
"version_requirement": ">= 4.10.0 < 7.0.0"
"version_requirement": ">= 5.5.8 < 7.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.5.10 is the latest in the 5 series

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://voxpupuli.org/blog/2019/01/03/dropping-puppet4/ we decided on 5.5.8 back in the days. I'm not sure if we should increase the patch version or not.

@bastelfreak bastelfreak merged commit d97dd6b into master Feb 1, 2019
@bastelfreak bastelfreak deleted the modulesync branch February 1, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants