Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated Hiera lookup warnings. Add default www pool in YAML. #522

Merged
merged 1 commit into from
May 30, 2019
Merged

Fix deprecated Hiera lookup warnings. Add default www pool in YAML. #522

merged 1 commit into from
May 30, 2019

Conversation

comport3
Copy link

Fix deprecated Hiera lookup warnings. Add YAML structure for default www pool so it can be overridden as needed.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak
Copy link
Member

Hi @comport3, thanks for the PR!

@bastelfreak bastelfreak merged commit 3c66d69 into voxpupuli:master May 30, 2019
@c33s
Copy link
Member

c33s commented May 30, 2019

shouldn't lookup functions should be avoided? they can lead to uncontrolled behavior as you can't override hardcoded lookup parameters. #434

@natemccurdy natemccurdy mentioned this pull request Sep 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@comport3 @bastelfreak @c33s @grant-veepshosting