Fix running apt update on Debian family #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix os::family name for Debian.
|
@Hexta thank you very much for your pull request. just for the records do you had a problem with the lowercase code? @bastelfreak wrote with me that puppet is case insentive in most cases. does the apt part not executed for you? |
|
@Hexta can you add a test to verify that the section is now correctly called if the os is |
Sorry, the issue was actually fixed in #555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix os::family name for Debian.
Pull Request (PR) description
Fix running apt update on Debian family.
Replace 'debian' by 'Debian' in family check in accordance with Facter family name constants: https://github.com/puppetlabs/facter/blob/2aa2d1cd6487f73fb8e311cf027dcf30c2166e28/lib/inc/facter/facts/os_family.hpp
This Pull Request (PR) fixes the following issues