Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The real_download_url in process-exporter manifest doesn't match to newer versions #212

Closed
dotSource-GmbH opened this issue Jun 15, 2018 · 1 comment · Fixed by #220
Closed
Labels
bug Something isn't working

Comments

@dotSource-GmbH
Copy link

The real_download_url in process-exporter manifest https://github.com/voxpupuli/puppet-prometheus/blob/master/manifests/process_exporter.pp
doesn't match to newer versions of process-exporter!

process-exporter 0.1
...${package_name}-${version}.${os}-${arch}.${download_extension}
https://github.com/ncabatoff/process-exporter/releases/download/v0.1.0/process-exporter-0.1.0.linux-amd64.tar.gz

process-exporter > 0.2
...${package_name}${version}${os}_${arch}.${download_extension}
https://github.com/ncabatoff/process-exporter/releases/download/v0.2.11/process-exporter_0.2.11_linux_amd64.tar.gz

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Jun 16, 2018
@bastelfreak
Copy link
Member

ugh what an annoying bug. Thanks for bringing this up @dotSource-GmbH! Are you able to provide a patch for this? Optimal way would be a case statement that sets teh correct url, depending on the provided version.

tuxmea pushed a commit to tuxmea/puppet-prometheus that referenced this issue Jun 23, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this issue Aug 28, 2019
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this issue May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants