add support for remote_read #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Nov 15, 2017
| @@ -144,6 +147,7 @@ | |||
| Hash $global_config = $::prometheus::params::global_config, | |||
| Array $rule_files = $::prometheus::params::rule_files, | |||
| Array $scrape_configs = $::prometheus::params::scrape_configs, | |||
| Array $remote_read_configs = $::prometheus::params::remote_read_configs, | |||
bastelfreak
reviewed
Nov 15, 2017
| @@ -2,13 +2,15 @@ | |||
| <% global_config = scope.lookupvar('::prometheus::global_config') -%> | |||
| <% rule_files = scope.lookupvar('::prometheus::rule_files') -%> | |||
| <% scrape_configs = scope.lookupvar('::prometheus::scrape_configs') -%> | |||
| <% remote_read_configs = scope.lookupvar('::prometheus::remote_read_configs') -%> | |||
There was a problem hiding this comment.
what happens when we get an empty array here?
There was a problem hiding this comment.
it ends up in the config as "remote_read": [] and prometheus just ignores it
required for prometheus 2 migration https://prometheus.io/docs/prometheus/2.0/migration/#storage
|
the tests seem fine now, but i can't get the debian test to pass, any ideas? |
|
Debian is our special snowflake. I've no idea why it never works on the first run, but always on the second. |
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
add support for remote_read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for prometheus 2 migration
https://prometheus.io/docs/prometheus/2.0/migration/#storage
example: